Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Allow user to switch between previous/next comment on timeline on scroll events #24

Open
S-trace opened this issue Jan 21, 2022 · 5 comments

Comments

@S-trace
Copy link

S-trace commented Jan 21, 2022

Hello.

It can be handy if the user can switch between previous/next comments using scroll events (vertical scroll or horizontal scroll). because some videos can have many comments in a short timeframe, and it is difficult to target the next mark even on regular videos in the current implementation.

Thank you.

@ris58h
Copy link
Owner

ris58h commented Feb 1, 2022

Duplicate of #8

@ris58h ris58h marked this as a duplicate of #8 Feb 1, 2022
@S-trace
Copy link
Author

S-trace commented Feb 2, 2022

This is not a duplicate of #8

I mean not to change the playback position to the position marked in a comment, but to switch between comments on the timeline.
Comments may have very close markers, which require very precise mouse positioning to read the next comment and is annoying. Using the scroll wheel to show previous/next comment text (if the user hovers the mouse over one of the comments marks on the timeline) can make this extension better, I think.

@S-trace
Copy link
Author

S-trace commented Feb 6, 2022

I have recorded a screencast for this issue.
Please take a look at it - to view the next comment on the timeline I need to move my mouse very precisely, which is not comfortable.

I have paused YouTube to show you only the effect I mentioned (and I had to reduce my mouse DPI to poison my mouse (I usually use 1000DPI precision, but reduced it to 400DPI for this,

2022-02-06.03.27.52.mp4

I think it may be useful to allow users to use mouse scroll events instead of cursor movement to switch previous/next comments (and even previous/next comments at all videos but not just around mouse pointer) without changing playback position.

@ris58h
Copy link
Owner

ris58h commented Feb 14, 2022

Video can't be played because the file is corrupt.

Unfortunately I couldn't watch the video, but I understand the issue.

I played with a scroll events a little bit. I decided to use vertical scroll to scroll long comments (it's already in the master but haven't released yet; see a0fac77). I'm not sure about UX of comments switching. Are you ok with horizontal scrolling for it?

UPD: version 0.5.2 is released.

@S-trace
Copy link
Author

S-trace commented Feb 17, 2022

Are you ok with horizontal scrolling for it?

Yes, using a horizontal scroll will be very intuitive in this context.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants