From 408841dc33cf0acdc556a305160aee418b00ab15 Mon Sep 17 00:00:00 2001 From: st1page <1245835950@qq.com> Date: Mon, 10 Apr 2023 20:57:05 +0800 Subject: [PATCH 1/2] chore: more error msg --- src/connector/src/sink/mod.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/connector/src/sink/mod.rs b/src/connector/src/sink/mod.rs index ca83e660b0af0..684a476fb93d1 100644 --- a/src/connector/src/sink/mod.rs +++ b/src/connector/src/sink/mod.rs @@ -274,7 +274,7 @@ fn datum_to_json_object(field: &Field, datum: DatumRef<'_>) -> ArrayResult { json!(v) } @@ -342,9 +342,10 @@ fn datum_to_json_object(field: &Field, datum: DatumRef<'_>) -> ArrayResult { - return Err(ArrayError::internal( - "datum_to_json_object: unsupported data type".to_string(), - )); + return Err(ArrayError::internal(format!( + "datum_to_json_object: unsupported data type {:?}, {:?}", + data_type, scalar_ref, + ))); } }; From 05317b39fd9b799dcfd3093c204e24ab739e7a5a Mon Sep 17 00:00:00 2001 From: st1page <1245835950@qq.com> Date: Mon, 10 Apr 2023 21:00:43 +0800 Subject: [PATCH 2/2] remove useless clone --- src/connector/src/sink/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/connector/src/sink/mod.rs b/src/connector/src/sink/mod.rs index 684a476fb93d1..0d47f777b4a5f 100644 --- a/src/connector/src/sink/mod.rs +++ b/src/connector/src/sink/mod.rs @@ -274,7 +274,7 @@ fn datum_to_json_object(field: &Field, datum: DatumRef<'_>) -> ArrayResult { json!(v) } @@ -344,7 +344,7 @@ fn datum_to_json_object(field: &Field, datum: DatumRef<'_>) -> ArrayResult { return Err(ArrayError::internal(format!( "datum_to_json_object: unsupported data type {:?}, {:?}", - data_type, scalar_ref, + field.data_type, scalar_ref, ))); } };