Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on rive::gpu::RenderContextMetalImpl::flush #350

Open
Dimentar opened this issue Dec 4, 2024 · 6 comments
Open

Crash on rive::gpu::RenderContextMetalImpl::flush #350

Dimentar opened this issue Dec 4, 2024 · 6 comments

Comments

@Dimentar
Copy link

Dimentar commented Dec 4, 2024

Good morning Rive Team

Thanks for creating this Library

Description

Once the new version of our App is released with integration of RiveRuntime SDK, we started observing new crashes from SDK side, the crashes are coming mostly from old devices as 'iPhone X, XR, SE`.

Crash Report

          Crashed: com.apple.main-thread
0  AGXMetalA12                    0x34438 -[AGXA12FamilyBlitContext generateMipmapsForTexture:]
1  RiveRuntime                    0x1cdd20 rive::gpu::RenderContextMetalImpl::flush(rive::gpu::FlushDescriptor const&) + 1480
2  RiveRuntime                    0x1cdd20 rive::gpu::RenderContextMetalImpl::flush(rive::gpu::FlushDescriptor const&) + 1480
3  RiveRuntime                    0x1ca750 rive::gpu::RenderContext::flush(rive::gpu::RenderContext::FlushResources const&) + 1312
4  RiveRuntime                    0x7968 -[RiveRendererContext endFrame:withCompletion:] + 140
5  RiveRuntime                    0x481c -[RiveRendererView drawInRect:withCompletion:] + 284
6  RiveRuntime                    0x48ec -[RiveRendererView drawRect:] + 100
7  MetalKit                       0x7494 -[MTKView draw] + 128
8  QuartzCore                     0x7eefc CA::Layer::layout_and_display_if_needed(CA::Transaction*) + 416
9  QuartzCore                     0xd9fd8 CA::Context::commit_transaction(CA::Transaction*, double, double*) + 464
10 QuartzCore                     0x4eee0 CA::Transaction::commit() + 648
11 QuartzCore                     0xd03c0 CA::Display::DisplayLink::dispatch_items(unsigned long long, unsigned long long, unsigned long long) + 1604
12 QuartzCore                     0xd0a70 display_timer_callback(__CFMachPort*, void*, long, void*) + 372
13 CoreFoundation                 0x54d68 __CFMachPortPerform + 176
14 CoreFoundation                 0x54ca4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 60
15 CoreFoundation                 0x54bc4 __CFRunLoopDoSource1 + 524
16 CoreFoundation                 0x53a0c __CFRunLoopRun + 2244
17 CoreFoundation                 0x52cd8 CFRunLoopRunSpecific + 608
18 GraphicsServices               0x11a8 GSEventRunModal + 164
19 UIKitCore                      0x40aae8 -[UIApplication _run] + 888
20 UIKitCore                      0x4bed98 UIApplicationMain + 340
21 App                  0x22fb8 main + 108 (AppDelegate.swift:108)
22 ???                            0x1cb403154 (Missing)   

Expected behavior

To not crash on any of devices

Device & Versions (please complete the following information)

  • Devices: iPhone X, XR, SE
  • iOS version iOS 18, 17, 16

Questions

  • Will the RiveRuntime SDK support the old iPhones ?
  • If not - Do you have any clue how it could be fixed on our side?

Firebase Screenshots

Screenshot 2024-12-04 at 09 57 46 Screenshot 2024-12-04 at 09 58 02
@dskuza
Copy link
Collaborator

dskuza commented Dec 4, 2024

Are you able to reproduce this locally in the simulator, or only in release builds on-device? Additionally, which version of the runtime are you using?

@Dimentar
Copy link
Author

Dimentar commented Dec 4, 2024

Hello

The issue is reproducible only on real devices as iPhone X, Xr, SE
We are using RiveRuntime 6.3.9

Thanks for quick reply

@dskuza
Copy link
Collaborator

dskuza commented Dec 5, 2024

Can you open a ticket here and attach any .riv file(s) you are using? I'll keep an eye out for an incoming ticket.

@Dimentar
Copy link
Author

Dimentar commented Dec 6, 2024

Hello @dskuza

I've created the ticket with ID RIV-7391

Thanks anticipated

@sarthak-mishra-swiggy
Copy link

@dskuza Any updates on this crash? We are facing this as well for one of our apps, we are using 6.5.2. Thanks!

@SleepiestAdam
Copy link

SleepiestAdam commented Jan 3, 2025

We're also getting this, reproduced on an iPhone 16 Pro. Un-clear if caused by a specific riv file, but very intermittent on-launch crash (we have rive animations both as the splash screen + on home screen).

Screenshot 2025-01-03 at 21 05 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants