Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a documentation example using Material UI Date Pickers? #4447

Open
1 task done
TheOneTheOnlyJJ opened this issue Jan 12, 2025 · 3 comments
Open
1 task done

Add a documentation example using Material UI Date Pickers? #4447

TheOneTheOnlyJJ opened this issue Jan 12, 2025 · 3 comments
Labels
docs feature Is a feature request

Comments

@TheOneTheOnlyJJ
Copy link

TheOneTheOnlyJJ commented Jan 12, 2025

Prerequisites

What theme are you using?

material-ui

What is your question?

Can a documentation example be added that showcases using the Material UI date and time pickers instead of the default browser pickers?

Creating such a widget is time-consuming, and many developers using the Material UI theme have to go through it.

A good example in the documentation that could be copy-pasted in codebases would save development time across many projects.

I'm sure there is at least someone around here who faced and solved this problem, and that experience would certainly be valuable for many others (including myself).

Update: I also opened an RFC on the Material UI side. Hopefully together we can come to a viable solution. mui/material-ui#45011

@nickgros
Copy link
Contributor

@TheOneTheOnlyJJ if it's any help, I have a wrapper over the '@mui/x-date-pickers' DateTimePicker you can reference here -- though I have no plan to formally port this

@heath-freenome
Copy link
Member

@TheOneTheOnlyJJ See the above comment as an example. Honestly, I think it would be a useful exercise for someone to implement the AltDateTimeWidget and AltDateWidget in the mui theme using the @mui/x-date-pickers. Interested? :)

@heath-freenome heath-freenome added docs feature Is a feature request and removed needs triage Initial label given, to be assigned correct labels and assigned question labels Jan 17, 2025
@TheOneTheOnlyJJ
Copy link
Author

TheOneTheOnlyJJ commented Jan 19, 2025

@TheOneTheOnlyJJ See the above comment as an example. Honestly, I think it would be a useful exercise for someone to implement the AltDateTimeWidget and AltDateWidget in the mui theme using the @mui/x-date-pickers. Interested? :)

This would make the most sense. I have opened the linked issue above in the Material UI repo for this purpose.

While I'm busy with uni and can't contribute, the linked example can progress this toward an actual implementation in the mui theme.

@nickgros Thank you very much for sharing this piece of code. Please also link it in mui/material-ui#45011, to make the team aware of this example.

It makes this issue way more likely to be resolved with an actual addition to the theme. A similar widget can be written for both the Date and Time picker as well. This would make the mui theme much better.

While there is no AltTimeWidget, could it be added to rjsf to make the potential mui version alternative to the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs feature Is a feature request
Projects
None yet
Development

No branches or pull requests

3 participants