-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Praise in Python #56
Comments
Sounds great! Maybe we should store the words in a format that can be shared between the projects? E.g. how about JSON files? |
Or, even simpler, a simple list of words, one per line? |
Good idea. So we don't need to maintain the list everywhere. But how can we share files in different repo? |
There are some options:
All of these are inconvenient, in different ways.... |
I can we can just sync manually. Some of use used (and will use) the praise package to teach GitHub pull requests, and then it would be confusing to have submodules, or multiple packages in a repo. We could still convert the text files to JSON or just text, though. How about that? |
Sounds good. Once you have the JSON or text file done, I can update the code. Then we sync it manually. |
This project is so great but I did find a Python version. So I made one and used some words in this project. I am still following the MIT licence and add the link to this project.
The Python version is at https://github.com/funtion/praise.
Hope this is OK for you. Feel free to contact me if you have any worries or comments.
Thanks
The text was updated successfully, but these errors were encountered: