You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
The main reason for this issue is that now it's really not obvious that status-bar mutates the state. For me, before I started maintaining this project, this module looks like a View rendering on top of everything other, with the position absolute. And that wasn't really clear that there is no state, but only mutations.
That can really lead the bugs. I want to make it more clear, that there is no rendering at all in the StatusBar component. Only mutation in the lifecycle hooks. And currently, codebase is a bit smells as from my point of view.
Solution
I am thinking about getting rid of the component at all. Just provide the hook.
produce a warning that the component is going away in the next major version so please migrate to hooks or imperative module calling (with links to migration guide)
Reason
The main reason for this issue is that now it's really not obvious that status-bar mutates the state. For me, before I started maintaining this project, this module looks like a
View
rendering on top of everything other, with the positionabsolute
. And that wasn't really clear that there is no state, but only mutations.That can really lead the bugs. I want to make it more clear, that there is no rendering at all in the
StatusBar
component. Only mutation in the lifecycle hooks. And currently, codebase is a bit smells as from my point of view.Solution
I am thinking about getting rid of the component at all. Just provide the hook.
This will internally use
useEffect
and will not make additional calling to the native module, as static methods right now.P.S.: This is open to discussion, want to know what @cpojer thinking about that.
The text was updated successfully, but these errors were encountered: