Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fileCopyUri to be null if copyTo not provided #481

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented Oct 6, 2021

Summary

motivation: fileCopyUri is now same as uri if no copyTo option was provided. This PR makes is so that fileCopyUri is specified only if copyTo is passed, otherwise is null. This makes the api a little cleaner.

Also made some other minor improvements to code.

Test Plan

tested on ios emulator and android device using the example app

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@vonovak vonovak merged commit 6ff5fd3 into master Oct 6, 2021
@vonovak vonovak deleted the feat/modify-copy-handling branch October 6, 2021 18:05
@tomgreco
Copy link

tomgreco commented Mar 3, 2022

I'm getting null sometimes when selecting +250 items and providing copyTo: 'cachesDirectory'.
Latest version of the library and latest version of iOS.

@vonovak
Copy link
Collaborator Author

vonovak commented Mar 4, 2022

I'm getting null sometimes when selecting +250 items and providing copyTo: 'cachesDirectory'.
Latest version of the library and latest version of iOS.

is something present in the error field then?

@tomgreco
Copy link

tomgreco commented Mar 4, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants