Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pick up correct android build tools version #509

Merged
merged 2 commits into from
Dec 11, 2021

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented Dec 11, 2021

Summary

closes #446, flags RNwindows as optional

Test Plan

android: tested in example project and seeing that this influences the "external libraries" in android studio, the settings does have effect

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@vonovak vonovak merged commit 1e5aa5e into master Dec 11, 2021
@vonovak vonovak deleted the fix/build-improvements branch December 11, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android API level update, requiring new apps to target API level 30 (Android 11) (Android SDK 30)
1 participant