Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate bundling node_modules #29

Open
robb-j opened this issue Jun 13, 2022 · 1 comment
Open

Investigate bundling node_modules #29

robb-j opened this issue Jun 13, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@robb-j
Copy link
Owner

robb-j commented Jun 13, 2022

It'd be nice to not rely on npmjs.com during install/runtime of the extension, from a very quick sketch:

# cd yaml.novaextension
tar -zcvf node_modules.tar.gz package.json package-lock.json node_modules

du -hs node*
# 18M	node_modules
# 3.3M	node_modules.tar.gz

Then the extension could untar the node_modules on startup and remove the tar (or rename to something like node_modules.tar.gz.bk so it knows not to do it again, but the tar is still there if needed. Alternatively it could update the package.json (and lock?) version(s) to that of the extension and only run the untar if the version has changed.

There could be a command to reinstall if required too, e.g. Extensions → YAML → Reinstall Server perhaps.

@robb-j robb-j added the enhancement New feature or request label Jun 13, 2022
@robb-j
Copy link
Owner Author

robb-j commented Jun 13, 2022

Related to #28 and #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant