Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre Shared Key not sticking when editing #4

Closed
NordloSydost-Pajje opened this issue May 6, 2023 · 3 comments · Fixed by #5
Closed

Pre Shared Key not sticking when editing #4

NordloSydost-Pajje opened this issue May 6, 2023 · 3 comments · Fixed by #5
Assignees
Labels
bug Something isn't working

Comments

@NordloSydost-Pajje
Copy link

NetBox version
What version of NetBox are you currently running?
3.5.1

Describe the bug
A clear and concise description of what the bug is.
When i edit an existing tunnel the Pre Shared Key does not remain. When the tunnel dispalys after edit the Pre Shared Key field is empty.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Tunnels'
  2. Click on 'Edit'
  3. Save
  4. Display Tunnel

Expected behavior
A clear and concise description of what you expected to happen.
The Pre Shared Key should remain as entered when created tunnel.

Alsow i would expect the preshared key be obfuscated whit a button to show Pre Shared key beside it. Security consern.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
RemoteDesktopManagerFree_l RemoteDesktopManagerFree_5TdCPut2nA r0Y7aWfC5
RemoteDesktopManagerFree_2vImzOsPlC

@NordloSydost-Pajje NordloSydost-Pajje added the bug Something isn't working label May 6, 2023
@robertlynch3
Copy link
Owner

I believe this has to do with the fact that the PSK is using the password widget.

psk = CharField(required=False, label="Pre-shared Key", widget=PasswordInput, help_text="Pre-shared key")

I don't believe the password widget is even necessary though because the PSK saved in plaintext and is displayed in plaintext when you look at the tunnel info.

@robertlynch3 robertlynch3 self-assigned this May 8, 2023
@NordloSydost-Pajje
Copy link
Author

I removed the password widget and now i works as expected!

Thanx!

@robertlynch3
Copy link
Owner

I am reopening because it's still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants