From 562b8671d1b12b159562f71ea5939ce3c45a0cff Mon Sep 17 00:00:00 2001 From: John MacFarlane Date: Thu, 21 Mar 2019 11:51:24 -0700 Subject: [PATCH] Remove now unused 'preserve_entities' option on escapeXml. This was formerly used (incorrectly) in the HTML renderer. It isn't needed any more. [API change] --- lib/common.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/common.js b/lib/common.js index ccc2a77a..3b2276e3 100644 --- a/lib/common.js +++ b/lib/common.js @@ -37,8 +37,6 @@ var XMLSPECIAL = '[&<>"]'; var reXmlSpecial = new RegExp(XMLSPECIAL, 'g'); -var reXmlSpecialOrEntity = new RegExp(ENTITY + '|' + XMLSPECIAL, 'gi'); - var unescapeChar = function(s) { if (s.charCodeAt(0) === C_BACKSLASH) { return s.charAt(1); @@ -80,13 +78,9 @@ var replaceUnsafeChar = function(s) { } }; -var escapeXml = function(s, preserve_entities) { +var escapeXml = function(s) { if (reXmlSpecial.test(s)) { - if (preserve_entities) { - return s.replace(reXmlSpecialOrEntity, replaceUnsafeChar); - } else { - return s.replace(reXmlSpecial, replaceUnsafeChar); - } + return s.replace(reXmlSpecial, replaceUnsafeChar); } else { return s; }