Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TEO files to teo-configuration-files #116

Closed
3 tasks done
jgvictores opened this issue Apr 26, 2017 · 23 comments
Closed
3 tasks done

Export TEO files to teo-configuration-files #116

jgvictores opened this issue Apr 26, 2017 · 23 comments
Assignees

Comments

@jgvictores
Copy link
Member

jgvictores commented Apr 26, 2017

Export TEO files (from share) to teo-configuration-files:

  • launchManipulation
  • launchLocomotion
  • ???
@rsantos88
Copy link
Contributor

You've this files:

  • checkCanBus
  • dumpCanBus
  • launchLocomotion
  • launchManipulation
  • oneCanBusOneWrapper
  • spaceNavigator
  • testCuiAbsolute

Do you want to export all?? especially, I have doubt with spaceNavigator

@jgvictores
Copy link
Member Author

The main idea is to move the teo-specific files, which usually mention manipulation or locomotion in its name. This is:

  • From share/checkCanBus/conf: checkCanBus.ini should stay; the rest should be moved (:truck:).
  • dumpCanBus: stay.
  • launchLocomotion: move (:truck:).
  • launchManipulation: move (:truck:).
  • oneCanBusOneWrapper: stay.
  • spaceNavigator: stay.
  • testCuiAbsolute: stay.

@PeterBowman
Copy link
Member

Don't delete launchManipulation.ini/launchLocomotion.ini, just keep a minimal working example. Compare with oneCanBusOneWrapper.ini: there is some placeholder data, but we'll want to preserve a template so that users may adjust it to their needs.

(I'd go a step ahead and merge both files into twoCanBusThreeWrappers.ini, see #20 (comment))

@jgvictores
Copy link
Member Author

@PeterBowman Let's agree on that final proposal, which involves the following workflow:

  1. Copy share/launchManipulation/conf/launchManipulation.ini to a new share/twoCanBusThreeWrappers/conf/twoCanBusThreeWrappers.ini.
  2. Move share/launchManipulation/conf/launchManipulation.ini and share/launchLocomotion/conf/launchLocomotion.ini to teo-configuration-files.

@jgvictores
Copy link
Member Author

PS: Don't worry about breaking things, I'll work on #20 as a follow-up to this issue.

@PeterBowman
Copy link
Member

@jgvictores OK!

@rsantos88
Copy link
Contributor

  1. Copy share/launchManipulation/conf/launchManipulation.ini to a new share/twoCanBusThreeWrappers/conf/twoCanBusThreeWrappers.ini.

done it here (2db6a0d)

@rsantos88
Copy link
Contributor

There are other files (maybe useful files) together with launchManipulation.ini (see) like launchManipulation-fake.ini. Do you want to move them too? or can I delete them?

@rsantos88
Copy link
Contributor

One note: I was thinking... twoCanBusThreeWrappers.ini not depend of any application, so... we can delete this and this lines if we want to install this file by default...?? or do you want use it like a example...

@PeterBowman
Copy link
Member

I'd keep them, we'll need this at #20.

BTW what do we need these comments for? It looks like 🗑️ and bloats the source code.

@jgvictores
Copy link
Member Author

Yep, essentially all the non-author-header cmake comment lines can be removed.

@jgvictores
Copy link
Member Author

And yes, something that requires twoCanBusThreeWrappers.ini will emerge from #20

@PeterBowman
Copy link
Member

Adding the blocked label as a notice/reminder that there is ongoing CMake-refactorization work at #26, which I'm going to close as soon as I get my hands on ASIBOT and run some tests. Don't let that block your progress, though, I'll fix any conflicts on my side if your commits are merged first.

@rsantos88
Copy link
Contributor

There are other files (maybe useful files) together with launchManipulation.ini (see) like launchManipulation-fake.ini. Do you want to move them too? or can I delete them?

and how about this?

@jgvictores
Copy link
Member Author

In general, I'd say move them. For the specific case of launchManipulation-fake.ini, delete, since FakeControlboard no longer exists.
Regarding the new twoCanBusThreeWrappers.ini we could fit in a FakeJoint somewhere to serve as example.

@rsantos88
Copy link
Contributor

rsantos88 commented Dec 11, 2017

  1. Move share/launchManipulation/conf/launchManipulation.ini and share/launchLocomotion/conf/launchLocomotion.ini to teo-configuration-files.

done it here

@rsantos88
Copy link
Contributor

Regarding the new twoCanBusThreeWrappers.ini we could fit in a FakeJoint somewhere to serve as example.

Do you want to replace some TechnosoftIpos by FakeJoint in twoCanBusThreeWrappers.ini.
For example... with the frontal wrists?

@jgvictores
Copy link
Member Author

Sure, great!

@PeterBowman
Copy link
Member

Adding the blocked label as a notice/reminder that there is ongoing CMake-refactorization work...

Unblocking, I'm going to close that issue as soon as file shuffling is over.

@rsantos88
Copy link
Contributor

done at (ee6ee02)

@jgvictores
Copy link
Member Author

@PeterBowman I think we're done with file shuffling. All yours, right?

@PeterBowman
Copy link
Member

@jgvictores done, thanks!

@jgvictores
Copy link
Member Author

Closing, as #26 is also closed! Thanks @rsantos88 @PeterBowman !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants