Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

human_wrench_provider returning zeros if not attached to HumanStateProvider #318

Closed
lrapetti opened this issue Sep 23, 2022 · 3 comments
Closed

human_wrench_provider returning zeros if not attached to HumanStateProvider #318

lrapetti opened this issue Sep 23, 2022 · 3 comments
Assignees
@lrapetti
Labels
type:bug

Comments

@lrapetti
Copy link
Member

After merging #309, the human_wrench_provider returns all zero if it is not attached to the HumanStateProvider, without returning any error. We should either make it work even without a HumanStateProvider attached, or return an error in case it is not present.

cc @RiccardoGrieco
@lrapetti lrapetti mentioned this issue Sep 23, 2022
Merged
@RiccardoGrieco
Copy link
Contributor

I will open a PR to address this issue. For the time being, #317 should be a good workaround.

@lrapetti
Copy link
Member Author

With #347, an error will be returned if no IHumanState interface is provided. We can wait for the PR and close it.

@lrapetti lrapetti self-assigned this Aug 31, 2023
@lrapetti
Copy link
Member Author

lrapetti commented Sep 6, 2023 •
edited
Loading

Closed via #347

@lrapetti lrapetti closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrapetti lrapetti

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RiccardoGrieco @lrapetti