Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ergoCub 1.1 S/N:001 – Problems when loading configuration files for torque control parameters #1718

Closed
DanielePucci opened this issue Jan 19, 2024 · 7 comments
Assignees
Labels
ergoCub 1.1 S/N:001 ergoCub1.1 platform

Comments

@DanielePucci
Copy link

DanielePucci commented Jan 19, 2024

Robot Name πŸ€–

ergoCub 1.1 S/N:001

Request/Failure description

Today, we started with @isorrentino to work to test the Yoga demo on the real robot after the preliminary results in https://github.com/ami-iit/element_qp-reactive-control/issues/70.

So, we started modifying the files for loading the parameters of torque control. See the commit ami-iit/robots-configuration@f6fe83c

Unfortunately, these parameters seem not loaded in the motor gui

image

And we cannot at the moment test the torque control since adding them manually for all the joints is a very long process

Detailed context

This is the output of yarprobotinterface
output_interface.txt

@Nicogene @sgiraz @maggia80

Additional context

No response

How does it affect you?

No response

@DanielePucci DanielePucci changed the title Problems when loading configuration for torque control parameters Problems when loading configuration files for torque control parameters Jan 19, 2024
@github-actions github-actions bot changed the title Problems when loading configuration files for torque control parameters ergoCub 1.1 S/N:001 – Problems when loading configuration for torque control parameters Jan 19, 2024
@github-actions github-actions bot added the ergoCub 1.1 S/N:001 ergoCub1.1 platform label Jan 19, 2024

This comment was marked as resolved.

@DanielePucci DanielePucci changed the title ergoCub 1.1 S/N:001 – Problems when loading configuration for torque control parameters ergoCub 1.1 S/N:001 – Problems when loading configuration files for torque control parameters Jan 19, 2024
@sgiraz
Copy link
Contributor

sgiraz commented Jan 19, 2024

Hi @DanielePucci,

The Parser seems to parse correctly the values set in config files:

...

(stictionUp 0 0 0) (stictionDown 0 0 0) (kff 1 1 1) (viscousPos 0 0 0) (viscousNeg 0 0 0) (coulombPos 0 0 0) (coulombNeg 0 0 0) (velocityThres 0.1 0.1 0.1) (filterType 0 0 0) (ktau 176 176 -176)"), ("OTHER_CONTROL_PARAMETERS" [group] = "(deadZone 0.0049 0.0049 0.0049)")]

...

I'm not sure, but as a first quick view to the info provided, it could be a (wrong) cast from float to int that trunkates the 0.1 to 0.
By the way, we'll perform some tests in during our next sprint (starting from Monday 22).

cc @Nicogene

@sgiraz sgiraz moved this from Triage to Backlog in iCub Tech Support Jan 19, 2024
@DanielePucci
Copy link
Author

Hi @sgiraz, thanks for the hint. We tried to set all parameters as integers, but it does not seem to solve the issue

image

Here's the log log_ergocub-torso_yarprobotinterface_18098.txt

@sgiraz sgiraz moved this from Backlog to Review/QA in iCub Tech Support Jan 22, 2024
@sgiraz
Copy link
Contributor

sgiraz commented Jan 22, 2024

Hi @DanielePucci,

I fixed a bug in icub-main that was preventing the parsing of torque parameters when the (⚠️ deprecated) kbemf parameter was missing. Here's the PR that addresses the issue:

cc @isorrentino @GiulioRomualdi @AntonioConsilvio

@DanielePucci
Copy link
Author

Thanks a lot @sgiraz, hopefully tomorrow we are going to give it a try!

@isorrentino
Copy link

Today, @DanielePucci and I tested the PR. Now everything works fine. Thanks a lot.

@sgiraz
Copy link
Contributor

sgiraz commented Jan 25, 2024

Hi @isorrentino, @DanielePucci

Thank you for your precious feedback.

I proceed closing this issue! βœ…

Cc @Nicogene @AntonioConsilvio

@sgiraz sgiraz closed this as completed Jan 25, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in iCub Tech Support Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ergoCub 1.1 S/N:001 ergoCub1.1 platform
Projects
Status: Done
Development

No branches or pull requests

4 participants