Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non collocated external wrenches estimation Berdy variant #991

Merged

Conversation

RiccardoGrieco
Copy link
Contributor

@RiccardoGrieco RiccardoGrieco commented May 16, 2022

This PR adds a new variant to the Berdy MAP Estimator for estimating the external wrenches acting on a multi-rigid body, which is the relation (25b) of https://ieeexplore.ieee.org/abstract/document/9526592.

The PR adds a new fictitious sensor for the Rate of Change of Momentum (RCM), which provides a new measurement for the berdy problem.

⚠️ WARNING

The Rate of Change of Momentum (RCM) should be computed in the CoM as per https://ieeexplore.ieee.org/abstract/document/9526592, but here the adjoint wrench transforms related to the RCM are not from the i-th link to the centroidal frame, but to the base one. For this reason Y*d will compute the sum of the estimated external wrenches transformed in the base frame, not the centroidal one.

For this reason, the measurement of the fictitious sensor should account for the bias terms generated by this transformation.

@RiccardoGrieco RiccardoGrieco force-pushed the feature/add-hierarchical_berdy_tasks branch from 5eb207f to cd01ed7 Compare June 23, 2022 09:22
@CLAassistant
Copy link

CLAassistant commented Jun 23, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ RiccardoGrieco
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@RiccardoGrieco RiccardoGrieco force-pushed the feature/add-hierarchical_berdy_tasks branch from f855f9d to 5811248 Compare July 6, 2022 15:40
@RiccardoGrieco RiccardoGrieco marked this pull request as ready for review July 7, 2022 12:38
@RiccardoGrieco
Copy link
Contributor Author

cc @traversaro

@RiccardoGrieco RiccardoGrieco force-pushed the feature/add-hierarchical_berdy_tasks branch from a889084 to c6c4d1c Compare July 7, 2022 13:59
@RiccardoGrieco RiccardoGrieco force-pushed the feature/add-hierarchical_berdy_tasks branch from cc489f8 to 6d0e015 Compare July 7, 2022 14:32
@RiccardoGrieco
Copy link
Contributor Author

@traversaro the PR is ready to be reviewed.

I suppose that the one check that is not completed is due to the fact that the commit where the matlab bindings have been regenerated are authored by a github action so we can ignore it.

@traversaro
Copy link
Member

Thanks, this seems nice!

Remaining points:

  • Do you want to curate the commits or I can merge with "Squash and merge"?
  • Can you add something on the ChangeLog related to this? In particular, it is important to document that the signature of the BerdyHelper::serializeDynamicVariables method changed, so downstream users need to change how they call it.

@RiccardoGrieco
Copy link
Contributor Author

  • Can you add something on the ChangeLog related to this? In particular, it is important to document that the signature of the BerdyHelper::serializeDynamicVariables method changed, so downstream users need to change how they call it.

Thanks, I didn't think about that. Added in 8dab362.

  • Do you want to curate the commits or I can merge with "Squash and merge"?

You can proceed with "Squash and merge"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants