Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly extracted mutations #10

Open
jhkbg opened this issue Oct 21, 2016 · 2 comments
Open

Incorrectly extracted mutations #10

jhkbg opened this issue Oct 21, 2016 · 2 comments
Assignees
Labels

Comments

@jhkbg
Copy link
Collaborator

jhkbg commented Oct 21, 2016

Some patterns return only partial matches against a longer mutation. Need to extend these patterns or create new, longer ones that have precedence over the shorter matches.

Examples:

  1. PMID=20806047 occurrence=p.X320SerextX72 extracted=p.X320Ser
  2. PMID=23903049 occurrence=p.His33GInfsX32 extracted=p.His33G
  3. PMID=22907560 occurrence=p.Arg313Hys extracted=p.Arg313H
  4. PMID=18486607 occurrence=p.Arg315Stop extracted=p.Arg315S
  5. PMID=23017188 occurrence=p.Phe508Del extracted=p.Phe508D
  6. PMID=24158885 occurrence=p.Met694IIe extracted=p.Met694I
  7. PMID=23856132 occurrence=p.F55>Lfs extracted=p.F55>L
  8. PMID=18708425 occurrence=p.L15_L16ins2L extracted=p.L15_L16ins2
@Erechtheus Erechtheus added the bug label Oct 29, 2016
@Erechtheus
Copy link
Collaborator

Erechtheus commented Nov 2, 2016

Thanks for the report. I added test-cases for the described errors here.

Some errors (3, 4, 5, 6) should be easy to fix. It seems that the parser stops too early in these cases. Other errors probably need some major adaption of the implemented Backus Naur grammar (e.g., 1,7,8).
https://github.com/rockt/SETH/blob/master/src/test/java/de/hu/berlin/wbi/issues/Request10Test.java

@jhkbg
Copy link
Collaborator Author

jhkbg commented Nov 2, 2016

Cool, thanks. I will look into this as well at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants