Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #237 add install flag for using the v3 forge api #238

Merged
merged 3 commits into from
Jul 22, 2014

Conversation

jhaals
Copy link
Contributor

@jhaals jhaals commented Jul 16, 2014

librarian-puppet install --use-v3-api adds support for downloading modules from a custom
Puppet forge using the v3 api

librarian-puppet install --use-v3-api adds support for downloading modules from a custom
Puppet forge using the v3 api
@carlossg
Copy link
Collaborator

I'd rather have a --v1 for backwards compatibility because going forward it's all going to be v3 by default. And could you add the usage to the docs?

Thanks!

The v1 API is still default but should be changed to false in future
versions. Specify --no-use-v1-api to use the new v3 API with a custom
Puppet Forge
@jhaals
Copy link
Contributor Author

jhaals commented Jul 17, 2014

That makes perfect sense @carlossg. I switched to --use-v1-api which is true by default. Should probably be switched to false in the next major release. So installig from a v3 forge will be --no--use-v1-api
Are you okay with the naming of the install flag? Do you want to documented under the How To Use section in the readme or someplace else?

@carlossg
Copy link
Collaborator

Thanks! name is fine, and all docs are in the readme.
Your custom forge is a Puppet Enterprise installation or something else?

@jhaals
Copy link
Contributor Author

jhaals commented Jul 17, 2014

I'll write something up right away

The current custom forge I'm using is written in Go https://github.com/jhaals/go-puppet-forge
It's probably a matter of time before other hosted forges move over to v3. Puppet Enterprise has no hosted forge.

carlossg added a commit that referenced this pull request Jul 22, 2014
fix #237 add install flag for using the v3 forge api
@carlossg carlossg merged commit 5fbeee3 into rodjek:master Jul 22, 2014
@carlossg
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants