Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undoing in Studio may undo Rojo changes #705

Closed
JohnnyMorganz opened this issue Jul 1, 2023 · 0 comments · Fixed by #708
Closed

Undoing in Studio may undo Rojo changes #705

JohnnyMorganz opened this issue Jul 1, 2023 · 0 comments · Fixed by #708
Labels
good first issue Looking to contribute to Rojo? This is a great place to start! impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin size: small type: enhancement Feature or improvement that should potentially happen

Comments

@JohnnyMorganz
Copy link
Contributor

Right now, it seems the Rojo plugin does not introduce ChangeHistoryService waypoints after a sync. This means if I later try to edit something in a partially managed project (e.g., move a part around) and undo that, it will also undo the changes that happened during the rojo sync.

Ideally, a waypoint should be created so that I don't accidently undo the Rojo changes as well
@boatbomber boatbomber added type: enhancement Feature or improvement that should potentially happen scope: plugin Relevant to the Roblox Studio plugin size: small impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. status: ready for work Ready to go! We would accept a PR to do this. good first issue Looking to contribute to Rojo? This is a great place to start! labels Jul 2, 2023
@boatbomber boatbomber mentioned this issue Jul 4, 2023
Merged
@boatbomber boatbomber added status: in-progress Someone is working on this last time we checked. and removed status: ready for work Ready to go! We would accept a PR to do this. labels Jul 4, 2023
@kennethloeffler kennethloeffler removed the status: in-progress Someone is working on this last time we checked. label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Looking to contribute to Rojo? This is a great place to start! impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin size: small type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Rojo breaking when users undo/redo in Studio boatbomber/rojo
3 participants
@kennethloeffler @JohnnyMorganz @boatbomber