Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch visualizer cannot show Instances that were removed during sync #714

Closed
boatbomber opened this issue Jul 8, 2023 · 1 comment · Fixed by #726
Closed

Patch visualizer cannot show Instances that were removed during sync #714

boatbomber opened this issue Jul 8, 2023 · 1 comment · Fixed by #726
Assignees
@boatbomber
Labels
impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. scope: plugin Relevant to the Roblox Studio plugin size: medium status: needs design Needs more planning before implementation type: bug Something happens that shouldn't happen

Comments

@boatbomber
Copy link
Member

boatbomber commented Jul 8, 2023 •
edited
Loading

Repro:

  • Sync a place
  • Open the patch visualizer by clicking on the changes info text
  • Delete a file while still syncing

You'll see the patch visuals totally empty, since that removal is for an instance that no longer exists so the visualizer cannot get information on it anymore.

image
@boatbomber boatbomber self-assigned this Jul 8, 2023
@boatbomber boatbomber added type: bug Something happens that shouldn't happen scope: plugin Relevant to the Roblox Studio plugin status: needs design Needs more planning before implementation size: medium impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. labels Jul 8, 2023
@boatbomber boatbomber mentioned this issue Jul 8, 2023
Closed
@boatbomber
Copy link
Member Author

The only way to be able to display information that has since been deleted is to store it, but I really don't want Rojo to need to store tree info on every object you have just in case you delete/rename it...

Perhaps the act of deleting could be modified so that when deleting something, we grab its info right before sending it to the abyss. Then that info is given to the patch viewer until the next patch comes in.

@boatbomber boatbomber mentioned this issue Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boatbomber boatbomber

Labels
impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. scope: plugin Relevant to the Roblox Studio plugin size: medium status: needs design Needs more planning before implementation type: bug Something happens that shouldn't happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework patch visualizer with many fixes and improvements boatbomber/rojo
1 participant
@boatbomber