Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recreate links that already exist #21

Closed
Corecii opened this issue May 4, 2024 · 1 comment · Fixed by #27
Closed

Don't recreate links that already exist #21

Corecii opened this issue May 4, 2024 · 1 comment · Fixed by #27
Labels
enhancement New feature or request

Comments

@Corecii
Copy link
Member

Corecii commented May 4, 2024

Recreating links that already exist can cause failure if any referenced tool is in use. This is common with Rojo and serving or watching for sourcemap changes.

Here's an example:
image

Re-writing links is not necessary. Similarly, re-writing already-installed tools is not necessary, but I don't actually know if rokit does that!

This has been an annoying issue with aftman, and it would be great to see it fixed in rokit!

@filiptibell filiptibell added the enhancement New feature or request label May 4, 2024
@filiptibell
Copy link
Collaborator

I think we can fix this. Rokit currently always re-creates links since each "link" is really just a copy of Rokit itself, and if Rokit updates, we obviously want the links (fake Rokits) to update too. What we could do though, is:

  1. Attach some metadata to the end of each link binary, that contains the Rokit version
  2. Seek the end of each link during link re-creation for this metadata
  3. If the version matches the current binary that is trying to re-create the links, we skip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants