Fix accepting different token types #60
Conversation
I perchance forgot to commit this
|
Sorry just realised I left the test in there, if someone could remove that then that’d be great 😅(as I’ve gotten off for the night) |
Co-authored-by: Micah <[email protected]>
|
Glad to see this. I switched to Rokit recently for a few things I'm working on, and the token auth issue completely severed my ability to publish packages via GitHub Actions.
Sidenote- this was already made, but it's currently nonfunctional due to the aforementioned issue. |
|
Yeah I didn't know that until yesterday but as long as someone's done it then that's fantastic! 😄 |
There was a problem hiding this comment.
Thank you for the PR and for fixing this! It seems like tracking down an official source on exactly what formats and prefixes the github tokens can have is challenging... so a solution like this one, matching against any github-like token, probably fits Rokit best.
I dont imagine it will cause any issues since the rokit authenticate github command also checks that the token is valid using the API.
Fixes accepting different token types
If no one’s got objections I’ve started writing up a draft of a GitHub action for rokit so I’d love to be the one to publish it if that’s okay.
Removing regex was @Dekkonot's suggestion so if you can somehow add him as a coauthor that'd be great!