-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not encoding as base64 breaks setups with xml escaping #172
Comments
If you are sure this is a bug, please take the time to refile this issue using the issue template. Hey there, thanks for opening an issue - Unfortunately you missed (or may have disregarded) the message about issue templates being required. Because our issue template was removed, we assume that this is a support request, and that's not something we offer here. Also, if you refile, please don't ignore Issue sections. They're in the template because they're useful to the maintainers of this project. |
@shellscape Sorry, was unaware there was anything useful in the tempalte. I updated the issue, could you reopen it |
@neoel this is frustrating for maintainers. The clip below is highlighted quite prominently in the issue template.
While I appreciate you replacing the removed template, you've removed parts of it and disregarded the instructions in the template, which pretty much nukes why we have it there in the first place. Most notably:
There can be a leaning curve when first starting to work with open source projects, but knowing how to interact and report issues properly on Github projects is a good skill to hone. We'll be happy to reopen the issue when you've taken the time to follow our template correctly. |
@shellscape Creating a Repl for this case is not going to be minimal, also this bug does not really fit your template nicely. I've updated it to explain the problems it has. Hope this is sufficient. |
Sorry, we don't have the bandwidth to triage issues without reproductions. |
How Do We Reproduce?
As it's quite involved setting up a svelte environment in a repl.it, I dont' have the time to do this atm. MR #136 introduced new behaviour (This update broke my workflow.)
That behaviour breaks existing setups as it's introducing html entities to the produced output by the imported images, and that is a security concern for many environments (as it's a vector for XSRF vurnerabilities).
Expected Behavior
Images should always be base64 encoded
Actual Behavior
SVG images allow for XSRF, since html entities are not encoded.
The text was updated successfully, but these errors were encountered: