Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

☂️ CLI #2316

Closed
2 of 3 tasks
NicholasLYang opened this issue Mar 28, 2022 · 6 comments
Closed
2 of 3 tasks

☂️ CLI #2316

NicholasLYang opened this issue Mar 28, 2022 · 6 comments
Labels
umbrella Issue to track a collection of other issues

Comments

@NicholasLYang
Copy link
Contributor

NicholasLYang commented Mar 28, 2022

Description

Description

The CLI is in an alpha state and needs some features/bug fixes

Tasks

@NicholasLYang NicholasLYang added the umbrella Issue to track a collection of other issues label Mar 28, 2022
@ematipico
Copy link
Contributor

About the third checkbox, it already does that: https://rome.tools/#use-the-formatter-with-the-cli

@NicholasLYang
Copy link
Contributor Author

With CI mode? What if I want to run the formatter and not exit if the files would get modified?

@MichaReiser
Copy link
Contributor

With CI mode? What if I want to run the formatter and not exit if the files would get modified?

What do you mean by not exiting? Do you mean that the program shouldn't end with a non zero exit code?

@ematipico
Copy link
Contributor

With CI mode? What if I want to run the formatter and not exit if the files would get modified?

Then the description of the requirement would require more details, so we can understand what exactly we need.

@NicholasLYang
Copy link
Contributor Author

I suppose we can codify it as a benchmark mode. Run, format the files but do not write them, so that you can run multiple iterations.

@yassere yassere added this to Rome 2022 May 8, 2022
@ematipico
Copy link
Contributor

Closing, as the log level it's not a priority and we haven't a meaty document with features that we need for the CLI.

Feel free to open it once we have a project in mind

@ematipico ematipico moved this to Done in Rome 2022 May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
umbrella Issue to track a collection of other issues
Projects
Status: Done
Development

No branches or pull requests

3 participants