From aa07c3a6cfa267652bc0d93e5513f3ef97f4aff8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Roni=20V=C3=A4yrynen?= <roni@vayrynen.info>
Date: Thu, 10 Oct 2024 08:59:25 +0300
Subject: [PATCH] fix: workaround for failing rhel installations for now

---
 README.md     |  2 ++
 xo-install.sh | 25 +++++++++++++------------
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/README.md b/README.md
index ed63ac7..611e479 100644
--- a/README.md
+++ b/README.md
@@ -49,6 +49,8 @@ Supported Linux distributions and versions:
 - Ubuntu 22.04
 - Ubuntu 20.04
 
+NOTE: RHEL based distros cannot do file level restore from backups in XO due to missing libvhdi-tools. See: https://github.com/ronivay/XenOrchestraInstallerUpdater/issues/256
+
 Only x86_64 architecture is supported. For all those raspberry pi users out there, check [container](https://hub.docker.com/r/ronivay/xen-orchestra) instead.
 
 All OS/Architecture checks can be disabled in `xo-install.cfg` for experimental purposes. Not recommended obviously.
diff --git a/xo-install.sh b/xo-install.sh
index 8980f9f..e31523c 100755
--- a/xo-install.sh
+++ b/xo-install.sh
@@ -241,19 +241,20 @@ function InstallDependenciesRPM {
         printok "Installing yarn"
     fi
 
+    # Disabled for now due to forensics.cert.org going away
     # only install libvhdi-tools if vhdimount is not present
-    if [[ -z $(runcmd_stdout "command -v vhdimount") ]]; then
-        echo
-        printprog "Installing libvhdi-tools"
-        if [[ "$INSTALL_REPOS" == "true" ]]; then
-            runcmd "rpm -ivh https://forensics.cert.org/cert-forensics-tools-release-el${OSVERSION}.rpm"
-            runcmd "sed -i 's/enabled=1/enabled=0/g' /etc/yum.repos.d/cert-forensics-tools.repo"
-            runcmd "dnf --enablerepo=forensics install -y libvhdi-tools"
-        else
-            runcmd "dnf install -y libvhdi-tools"
-        fi
-        printok "Installing libvhdi-tools"
-    fi
+    #    if [[ -z $(runcmd_stdout "command -v vhdimount") ]]; then
+    #        echo
+    #        printprog "Installing libvhdi-tools"
+    #        if [[ "$INSTALL_REPOS" == "true" ]]; then
+    #            runcmd "rpm -ivh https://forensics.cert.org/cert-forensics-tools-release-el${OSVERSION}.rpm"
+    #            runcmd "sed -i 's/enabled=1/enabled=0/g' /etc/yum.repos.d/cert-forensics-tools.repo"
+    #            runcmd "dnf --enablerepo=forensics install -y libvhdi-tools"
+    #        else
+    #            runcmd "dnf install -y libvhdi-tools"
+    #        fi
+    #        printok "Installing libvhdi-tools"
+    #    fi
 
     echo
     printprog "Enabling and starting redis service"