feat: no_support_multi_text_direction #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronnnnn
added
docs
|
WalkthroughThe changes primarily introduce a new lint rule Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (9)
- packages/nilts/README.md (3)
- packages/nilts/lib/nilts.dart (2)
- packages/nilts/lib/src/change_priority.dart (1)
- packages/nilts/lib/src/lints/no_support_multi_text_direction.dart (1)
- packages/nilts_test/test/lints/defined_void_callback_type.dart (1)
- packages/nilts_test/test/lints/fixed_text_scale_rich_text.dart (1)
- packages/nilts_test/test/lints/no_support_multi_text_direction.dart (1)
- packages/nilts_test/test/lints/shrink_wrapped_scroll_view.dart (1)
- packages/nilts_test/test/lints/unnecessary_rebuilds_from_media_query.dart (1)
Files not summarized due to errors (1)
- packages/nilts/lib/src/lints/no_support_multi_text_direction.dart (diff tokens exceeds limit)
Files not reviewed due to errors (4)
- packages/nilts/lib/src/change_priority.dart (no response)
- packages/nilts/README.md (no response)
- packages/nilts_test/test/lints/shrink_wrapped_scroll_view.dart (no response)
- packages/nilts/lib/src/lints/no_support_multi_text_direction.dart (no response)
Files skipped from review due to trivial changes (3)
- packages/nilts_test/test/lints/defined_void_callback_type.dart
- packages/nilts_test/test/lints/fixed_text_scale_rich_text.dart
- packages/nilts_test/test/lints/unnecessary_rebuilds_from_media_query.dart
Review comments generated (6)
- Review: 3
- LGTM: 3
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
| import 'package:flutter/material.dart'; | ||
|
|
||
| class Alignments extends StatelessWidget { | ||
| const Alignments({super.key}); |
There was a problem hiding this comment.
The super.key is not a valid constructor for the StatelessWidget. It should be Key key and passed to the super class.
- const Alignments({super.key});
+ const Alignments({Key key}) : super(key: key);| } | ||
|
|
||
| class Insets extends StatelessWidget { | ||
| const Insets({super.key}); |
There was a problem hiding this comment.
Same issue as above, super.key is not a valid constructor for the StatelessWidget. It should be Key key and passed to the super class.
- const Insets({super.key});
+ const Insets({Key key}) : super(key: key);| } | ||
|
|
||
| class Positions extends StatelessWidget { | ||
| const Positions({super.key}); |
There was a problem hiding this comment.
Again, super.key is not a valid constructor for the StatelessWidget. It should be Key key and passed to the super class.
- const Positions({super.key});
+ const Positions({Key key}) : super(key: key);
This was referenced Aug 27, 2024
This was referenced Sep 5, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
New lint rule
no_support_multi_text_directionand quick fixes.Feature type