From 827d68c54bdd50d488aa881390fb9c45fca28092 Mon Sep 17 00:00:00 2001 From: Adam Rice Date: Thu, 26 Dec 2024 18:23:47 +1100 Subject: [PATCH] Don't globally set Encoding.default_external Using Encoding.default_external is a global override that can cause problems with other libraries and Ruby now throws warnings about setting this value. After removing this setting, the test suite still passes so, if this is still needed in certain circumstances, it should be set in a way that is scoped to the code that needs it --- test/test_roo.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/test_roo.rb b/test/test_roo.rb index bd1188de..247c9472 100644 --- a/test/test_roo.rb +++ b/test/test_roo.rb @@ -4,8 +4,6 @@ # with the wrong spreadsheet class #STDERR.reopen "/dev/null","w" -Encoding.default_external = "UTF-8" - require 'test_helper' require 'stringio'