Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support client access control for NFS volumes #5

Closed
rohan47 opened this issue Nov 15, 2018 · 10 comments
Closed

Support client access control for NFS volumes #5

rohan47 opened this issue Nov 15, 2018 · 10 comments

Comments

@rohan47
Copy link
Member

rohan47 commented Nov 15, 2018

Is this a bug report or feature request?

  • Feature Request

What should the feature do:
Currently, the NFS export can be accessed by any client. This feature will restrict volume access to specified clients and also it will implement squash and access control per client/clients as per the NFS CRD design doc. An example of this can be found here

@rohan47
Copy link
Member Author

rohan47 commented Nov 15, 2018

nfsservers.nfs.rook.io type already supports the allowed clients https://github.com/rook/rook/blob/master/pkg/apis/nfs.rook.io/v1alpha1/types.go#L84

@tsullens
Copy link
Contributor

I can do this if you want to assign it to me.

@rohan47
Copy link
Member Author

rohan47 commented Nov 19, 2018

@tsullens sure, go ahead.

tsullens referenced this issue in tsullens/rook Nov 30, 2018
adding functionality and tests for issue #2283

Signed-off-by: Tyler Sullens <[email protected]>
tsullens referenced this issue in tsullens/rook Dec 19, 2018
adding functionality and tests for issue #2283

Signed-off-by: Tyler Sullens <[email protected]>
tsullens referenced this issue in tsullens/rook Dec 23, 2018
adding functionality and tests for issue #2283

Signed-off-by: Tyler Sullens <[email protected]>
tsullens referenced this issue in tsullens/rook Jan 28, 2019
adding functionality and tests for issue #2283

Signed-off-by: Tyler Sullens <[email protected]>
tsullens referenced this issue in tsullens/rook Jan 29, 2019
adding functionality and tests for issue #2283

Signed-off-by: Tyler Sullens <[email protected]>
@sourabh1031
Copy link

@rohan47 can i work on it

@rohan47
Copy link
Member Author

rohan47 commented Mar 4, 2019

@sourabh1031 there is a PR by @tsullens for this rook/rook#2315. We haven't seen any activity from him for a month. @jbw976 what do you suggest?

@tsullens
Copy link
Contributor

tsullens commented Mar 4, 2019

@sourabh1031 @rohan47 I apologize as I've gotten a bit busy and never finished this up.
The PR as-is adds this functionality but lacks an appropriate integration test for it. I'm more than fine with @sourabh1031 finishing up the PR and maybe we should have a separate issue for the integration test?

@jbw976
Copy link
Member

jbw976 commented Apr 23, 2019

Added a comment to the PR @tsullens @rohan47

rook/rook#2315 (comment)

@stale
Copy link

stale bot commented Jul 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Jul 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jul 29, 2019

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@stale stale bot closed this as completed Jul 29, 2019
@BlaineEXE BlaineEXE transferred this issue from rook/rook Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants