Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

404 page #76

Closed
s-vamshi opened this issue Oct 6, 2022 · 10 comments · Fixed by #90
Closed

404 page #76

s-vamshi opened this issue Oct 6, 2022 · 10 comments · Fixed by #90
Assignees
Labels
bug Something isn't working hacktoberfest hacktoberfest in progress

Comments

@s-vamshi
Copy link
Contributor

s-vamshi commented Oct 6, 2022

Is your feature request related to a problem? Please describe.
Whenever we enter a route which doesn't exists then the page is shows only navbar and search bar and remains blank below it.

Describe the solution you'd like
I think we need to tell user that the page they are referring doesn't exists.
So i would like to build 404 page which tells user that the page doesn't exists.

Describe alternatives you've considered
And i have an idea to show random recipes to the user on this 404 page.

Additional context
This is how it looks as of now when page doesn't exists -
tem9

@roopeshsn
Copy link
Owner

You can work on this @s-vamshi Thanks for your interest in this project!

@roopeshsn roopeshsn added bug Something isn't working hacktoberfest hacktoberfest in progress labels Oct 8, 2022
@s-vamshi
Copy link
Contributor Author

@roopeshsn

This is how 404 page looks in desktop -
tem17

And in mobile -
screencapture-localhost-3000-a-2022-10-10-13_05_37

Is this ok?

@roopeshsn
Copy link
Owner

Hi, @s-vamshi This 404 page looks cluttered and aligned to our application theme. It will be good if you adopt a minimal design.

@s-vamshi
Copy link
Contributor Author

@roopeshsn is it ok if I remove the vegetables image at the left?

@s-vamshi
Copy link
Contributor Author

Hi, @s-vamshi This 404 page looks cluttered and aligned to our application theme. It will be good if you adopt a minimal design.

And should I remove the random dishes component or should i make any changes to it?, any thoughts on this?

@roopeshsn
Copy link
Owner

roopeshsn commented Oct 10, 2022

Here's the design for the 404 page,

404_page_freshbey

Something like this will be fine. For the "Take me home" button use the same button we have for "Add to cart". Also, include Header and Footer with this 404 design. Nothing else should be present on the screen.

@s-vamshi
Copy link
Contributor Author

@roopeshsn got it and working on it.

@s-vamshi
Copy link
Contributor Author

Is it ok?
Desktop view -
screencapture-localhost-3000-a-2022-10-10-20_41_55
Mobile view -
tem19

@roopeshsn
Copy link
Owner

It will be nice if it was at the center of the page. Also the font weight of the "Take me home" text can be reduced.

@s-vamshi
Copy link
Contributor Author

I have made the changes can you please check?

screencapture-localhost-3000-a-2022-10-11-08_21_10

screencapture-localhost-3000-a-2022-10-11-11_17_47

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working hacktoberfest hacktoberfest in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants