-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
last_response still fetches all responses #153
Comments
Well. This is rather embarrassing. 🙈 I haven't noticed this since taking over maintenance over this package, but the So where does that leave us? I am going to need to deprecate this argument because the API doesn't work like this. Thanks for bringing this to my attention, and I apologize for the confusion! |
Good to know and thank you! the package is a lifesaver |
Just found this in # No longer used:
# if ("last_response" %in% names(args)) {
# if (!is.null(args$last_response)) {
# assert_lastResponseId_string(args$last_response)
# } |
The warning users will see will look like this:
|
Sorry, @juliasilge. You should brush off that embarrassment and send it my way. The older response API endpoint DID have had a The new API doesn't support anything quite like it, though. There are "continuation tokens" but we don't support them yet, and they require some forethought to work. However, @weiyangtham, I think you could get the same effect by pulling RecordedDate from the last response and passing that to You'd need to format it properly, though, see here: EDIT: this won't work yet because of how the payload is internally constructed. We'd need to handle start_date a bit more flexibly first, to include times as well as dates. |
I'm otherwise able to get the responses with
fetch_survey
, but even when I enter a response ID intolast_response
, I get all the responses instead of only those after the response ID. I've tried those on a couple of different projects without successThe text was updated successfully, but these errors were encountered: