Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buoy test failures - see if this is just temporary or if need to fix fxn #251

Closed
sckott opened this issue Jan 23, 2018 · 1 comment
Closed
Labels
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Jan 23, 2018

test-buoy.R:31: error: buoy works
length(url) == 1 is not TRUE
1: buoy(dataset = "cwind", buoyid = 41001, year = 2008, datatype = "cc") at /Users/sckott/github/ropensci/rnoaa/tests/testthat/test-buoy.R:31
2: get_ncdf_file(path = toget, buoyid, file = files[[1]], output) at /Users/sckott/github/ropensci/rnoaa/R/buoy.R:82
3: GET(path) at /Users/sckott/github/ropensci/rnoaa/R/buoy.R:138
4: handle_url(handle, url, ...)
5: handle_find(url)
6: handle_name(url)
7: build_url(parse_url(url)[c("scheme", "hostname", "port")])
8: stopifnot(is.url(url))
9: is.url(url)
10: inherits(x, "url")
11: parse_url(url)
12: stopifnot(length(url) == 1)
13: stop(msg, call. = FALSE, domain = NA)

test-buoy.R:74: failure: buoys fails well
`buoy(dataset = "ocean", buoyid = 41012)` threw an error with unexpected message.
Expected match: "No data files found"
Actual message: "length(url) == 1 is not TRUE"
@sckott sckott added the bug label Jan 23, 2018
@sckott sckott added this to the v0.8 milestone Oct 25, 2018
@sckott
Copy link
Contributor Author

sckott commented Oct 25, 2018

fixed in e847467 i think

@sckott sckott closed this as completed Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant