Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inform users when using cached data, maybe include last mod date of the file? #331

Closed
3 tasks done
sckott opened this issue Nov 5, 2019 · 1 comment
Closed
3 tasks done
Labels
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Nov 5, 2019

to avoid situations like in #330 this is needed

For all fxns that use caching:

  • throw a message when a cached file is being used, include in it:
    • the complete file path
    • created date so the user can think about whether to delete the file
  • don't throw a message when a HTTP request is made to get new data
  • with a lot of requests messages could get annoying. have a flag to turn cached file messages off? probably do not want this on by default since then we're back to where we are now with users possibly confused about why they're not getting up to date data
@sckott sckott added this to the v1.0 milestone Nov 5, 2019
@sckott sckott modified the milestones: v1.0, v0.9.6 Nov 30, 2019
@sckott sckott added the caching label Mar 23, 2020
@sckott
Copy link
Contributor Author

sckott commented Mar 23, 2020

woops, missed issue 32d5f53

@sckott sckott closed this as completed in bd97af8 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant