Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention httr system deps in README #37

Closed
mbjoseph opened this issue Jul 23, 2018 · 1 comment
Closed

Mention httr system deps in README #37

mbjoseph opened this issue Jul 23, 2018 · 1 comment

Comments

@mbjoseph
Copy link
Member

@marcosci pointed out that it might be useful to mention the system dependencies for the httr package in the installation instructions (ropensci/software-review#231). On Debian systems this is libssl-dev and [email protected] via brew for macOS.

@mbjoseph
Copy link
Member Author

Actually - I think it makes more sense not to do this, as these system deps are already well handled by the httr package. If a user tries to install it without the proper system deps, they will get a nice error message, e.g.,

------------------------ ANTICONF ERROR ---------------------------
Configuration failed because openssl was not found. Try installing:
 * deb: libssl-dev (Debian, Ubuntu, etc)
 * rpm: openssl-devel (Fedora, CentOS, RHEL)
 * csw: libssl_dev (Solaris)
 * brew: [email protected] (Mac OSX)
If openssl is already installed, check that 'pkg-config' is in your
PATH and PKG_CONFIG_PATH contains a openssl.pc file. If pkg-config
is unavailable you can set INCLUDE_DIR and LIB_DIR manually via:
R CMD INSTALL --configure-vars='INCLUDE_DIR=... LIB_DIR=...'
--------------------------------------------------------------------
ERROR: configuration failed for package ‘openssl’

So, that should provide a better hint (and one that does not need to be maintained as part of the smapr package) over the long term, consistent with the idea that the R packages smapr depends on are responsible for handling their own system dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant