Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Process! (RELEASED! PENDING SYNC) 🟢 #4

Open
10 of 11 tasks
methylDragon opened this issue Apr 8, 2022 · 7 comments
Open
10 of 11 tasks

Release Process! (RELEASED! PENDING SYNC) 🟢 #4

methylDragon opened this issue Apr 8, 2022 · 7 comments

Comments

@methylDragon
Copy link
Contributor

methylDragon commented Apr 8, 2022

[STATUS: PENDING SYNC PR UPDATE]

Buildfarm Status

  • Build Status dev (ubuntu_jammy_amd64)
  • Build Status doc (ubuntu_jammy_amd64)
  • Build Status src (rhel_8)
  • Build Status src (ubuntu_jammy)
  • Build Status bin (ubuntu_jammy_amd64)
  • Build Status bin (rhel_8_x86_64)
  • Build Status bin (ubuntu_jammy_arm64)

Description

This issue tracks the status for the release of this repository into rosdistro and making it available for installation as .deb via the ROS 2 repositories.

It will detail the steps that need to be taken, and what recommended changes are good to have.

Release Process

Steps

Recommendations

@methylDragon
Copy link
Contributor Author

Let's make the branches too!

The release repo is in progress as well.

@methylDragon methylDragon changed the title Release Process! (Reviewing...) [DRAFT/WIP] Release Process! (CHANGES REQUIRED. Recommendations in review...) Apr 11, 2022
@methylDragon
Copy link
Contributor Author

Note on including rclcpp_components. I understand this one isn't strictly necessary since rclcpp is a superset, but since it's in the CMakeLists.txt, it's just nice to make it explicit.

@vmayoral
Copy link
Member

Note on including rclcpp_components. I understand this one isn't strictly necessary since rclcpp is a superset, but since it's in the CMakeLists.txt, it's just nice to make it explicit.

Thanks for the note and the PR #5. Merged.

@methylDragon
Copy link
Contributor Author

methylDragon commented Apr 13, 2022

Let's get the new branches and release tag so we can bloom this 👀

Aside from that I don't really see any huge issues with this package (at least at this juncture it has less places for improvement than the colcon extension package, haha...)

But I'd like to spend some time continuing to run the examples in the tutorial as well.

@vmayoral
Copy link
Member

vmayoral commented Apr 13, 2022

@methylDragon
Copy link
Contributor Author

You need to attach rolling and docs info.

See example:

  ament_vitis:
    doc:
      type: git
      url: https://github.com/ros-acceleration/ament_vitis.git
      version: rolling
    release:
      tags:
        release: release/rolling/{package}/{version}
      url: https://github.com/ros2-gbp/ament_vitis-release.git
      version: 0.10.1-1
    source:
      test_pull_requests: true
      type: git
      url: https://github.com/ros-acceleration/ament_vitis.git
      version: rolling
    status: developed

Specifically you need version: rolling and the doc sections.

@vmayoral
Copy link
Member

Good catch. See ros/rosdistro#32774

@methylDragon methylDragon changed the title Release Process! (CHANGES REQUIRED. Recommendations in review...) Release Process! (PENDING ROSDISTRO PR UPDATE) Apr 14, 2022
@methylDragon methylDragon changed the title Release Process! (PENDING ROSDISTRO PR UPDATE) Release Process! (RELEASED! PENDING ROSDISTRO PR UPDATE) 🟢 Apr 14, 2022
@methylDragon methylDragon changed the title Release Process! (RELEASED! PENDING ROSDISTRO PR UPDATE) 🟢 Release Process! (RELEASED! PENDING SYNC) 🟢 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants