Create usable workflows #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI on this should be green using your fork, right? |
|
this one here won't go green unless it is merged into master. But in other repos, like in the linked one in the demos I think so yes |
Co-authored-by: Christoph Fröhlich <[email protected]>
bmagyar
approved these changes
Jun 30, 2023
|
Let's see |
This was referenced Jul 1, 2023
This was referenced Jul 1, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 12, 2023
* Create usable workflow for dependencies * Checkout repository before git config --local * Single job only * Use checkout * Try composite action * Optionally checkout PR instead of master branch * Update comment * Add reusable workflow for single version * Fix repository for checkout action * Fix repository for checkout action * Fix repository+ref for checkout action * try to fix source of action * Add fetch-depth again * Use correct head info * Halt on errors * use master branch ref Co-authored-by: Christoph Fröhlich <[email protected]> --------- Co-authored-by: Bence Magyar <[email protected]> (cherry picked from commit e2a04ea) # Conflicts: # .github/workflows/reusable-sphinx-check-single-version.yml # .github/workflows/sphinx-check-links.yml # .github/workflows/sphinx-check-warnings.yml # Makefile # make_help_scripts/deploy_defines
christophfroehlich
pushed a commit
that referenced
this pull request
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a reusable workflow as proposed in ros-controls/ros2_controllers#664 (comment)
This should enable CI workflows in other repositories, which can check if the docs are building fine.
As an example, this works already with ros-controls/ros2_control_demos#303
One has to explicitly state the repo in the reusable workflow, otherwise the job from the caller workflow looks inside its repo for the action/reusable workflow. (or have I missed someting?)
Because the workflow is not in the master branch, I had to use my fork -> I'll change that before the merge.
CI for this PR fails, because the Cleanup jobs switch to the master branch, where the composable action is not available obviously