Skip to content

Commit

Permalink
Fix unused timeouts in load/unload controller (#2052)
Browse files Browse the repository at this point in the history
  • Loading branch information
bijoua29 authored Feb 17, 2025
1 parent 3e253fc commit 45f871e
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions controller_manager/controller_manager/spawner.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,13 @@ def main(args=None):
):
return 1

ret = load_controller(node, controller_manager_name, controller_name)
ret = load_controller(
node,
controller_manager_name,
controller_name,
controller_manager_timeout,
service_call_timeout,
)
if not ret.ok:
node.get_logger().fatal(
bcolors.FAIL
Expand Down Expand Up @@ -338,7 +344,13 @@ def main(args=None):

unload_status = True
for controller_name in controller_names:
ret = unload_controller(node, controller_manager_name, controller_name)
ret = unload_controller(
node,
controller_manager_name,
controller_name,
controller_manager_timeout,
service_call_timeout,
)
if not ret.ok:
unload_status = False
node.get_logger().error(
Expand Down

0 comments on commit 45f871e

Please sign in to comment.