Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new get_value API for newly added tests and semantic components #2055

Conversation

saikishor
Copy link
Member

I missed these in #1976 as these were added in the recent PRs of #2000 and #2011

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (9394fd2) to head (1637d59).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2055      +/-   ##
==========================================
+ Coverage   89.34%   89.44%   +0.09%     
==========================================
  Files         139      139              
  Lines       14994    14973      -21     
  Branches     1285     1281       -4     
==========================================
- Hits        13396    13392       -4     
+ Misses       1115     1103      -12     
+ Partials      483      478       -5     
Flag Coverage Δ
unittests 89.44% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...terface/include/semantic_components/gps_sensor.hpp 100.00% <100.00%> (ø)
hardware_interface/test/test_handle.cpp 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit d126642 into ros-controls:master Feb 19, 2025
23 of 25 checks passed
@christophfroehlich christophfroehlich deleted the use/new_api/hardware_interface/tests branch February 19, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants