Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check seed for validity #24

Open
simonschmeisser opened this issue May 7, 2020 · 1 comment
Open

Check seed for validity #24

simonschmeisser opened this issue May 7, 2020 · 1 comment

Comments

@simonschmeisser
Copy link
Contributor

StompSmoothingAdapter:

Currently validity (ie collision free) is only checked after the first iteration. This means that even though a valid seed is given, STOMP might invalidate this during it's first iteration and never recover. This has led to discussions about an additional option allowing the adapter to fail and return the seed as a fall-back solution.

I propose to

  1. calculate the cost of the seed and thereby see if it's valid
  2. discuss about whether num_iteration_after_valid: 0 should then be ignored and still at least one iteration performed
  3. add an option to fail if the cost of the trajectory did not improve, returning the seed iff valid otherwise, fail if it isn't

this is a continuation of the discussion in #7 and #20

@jrgnicho
Copy link
Member

@simonschmeisser I'm on board with making stop evaluate the cost of the seed trajectory prior to the first iteration, it should be a matter of tweaking the main loop of stomp here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants