Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav2_util::get_node_options_default is dead code #3072

Closed
Aposhian opened this issue Jul 12, 2022 · 1 comment · Fixed by #3073
Closed

nav2_util::get_node_options_default is dead code #3072

Aposhian opened this issue Jul 12, 2022 · 1 comment · Fixed by #3073

Comments

@Aposhian
Copy link
Contributor

Feature request

Feature description

get_node_options_default is not used anywhere in Nav2. It was misleading me by thinking those default settings were being applied everywhere, when they are actually applied nowhere.

Implementation considerations

Some users may be using nav2_util::get_node_options_default in their own code. I don't know how we sunset it without breaking people's code. Add a compile time deprecation warning?

@SteveMacenski
Copy link
Member

Removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants