Better use of numpy #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very late but thx ! |
nuclearsandwich
pushed a commit
to ros/rosdistro
that referenced
this pull request
Apr 22, 2019
Increasing version of package(s) in repository `laser_geometry` to `2.0.0-0`: - upstream repository: https://github.com/ros-perception/laser_geometry.git - release repository: https://github.com/ros2-gbp/laser_geometry-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.7.2` - previous version for package: `null` ## laser_geometry ``` * Removed the ``angle`` dependency as no longer necessary. * Updated to build statically but use position independent code. * Updated to compile, and to remove PointCloud support, and remove boost. * Added visibility headers modified from ``rclcpp``. * Updated ``laser_geometry`` to build for ros2 (and on Windows 10). * Improved use of numpy. (#14 <ros-perception/laser_geometry#14>) * Contributors: Alessandro Bottero, Andreas Greimel, Brian Fjeldstad, Eric Wieser, Jon Binney, Jonathan Binney, Martin Idel, Mikael Arguedas, Vincent Rabaud, William Woodall ```
andre-rosa
pushed a commit
to andre-rosa/rosdistro
that referenced
this pull request
May 3, 2019
…0976) Increasing version of package(s) in repository `laser_geometry` to `2.0.0-0`: - upstream repository: https://github.com/ros-perception/laser_geometry.git - release repository: https://github.com/ros2-gbp/laser_geometry-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.7.2` - previous version for package: `null` ## laser_geometry ``` * Removed the ``angle`` dependency as no longer necessary. * Updated to build statically but use position independent code. * Updated to compile, and to remove PointCloud support, and remove boost. * Added visibility headers modified from ``rclcpp``. * Updated ``laser_geometry`` to build for ros2 (and on Windows 10). * Improved use of numpy. (ros#14 <ros-perception/laser_geometry#14>) * Contributors: Alessandro Bottero, Andreas Greimel, Brian Fjeldstad, Eric Wieser, Jon Binney, Jonathan Binney, Martin Idel, Mikael Arguedas, Vincent Rabaud, William Woodall ```
ivanpauno
pushed a commit
to ivanpauno/laser_geometry
that referenced
this pull request
Nov 2, 2020
…-perception#14) * Remove return of std::move from fromMsg for Time. Windows VC++ was complaining that we were returning a pointer to a temporary. To avoid this, don't return a pointer, and just construct and return an object, which C++11 should be able to elide the copy for (see http://stackoverflow.com/questions/14856344/when-should-stdmove-be-used-on-a-function-return-value Signed-off-by: Chris Lalancette <[email protected]> * Fix silly typos. Signed-off-by: Chris Lalancette <[email protected]> * Make getTimestamp not return const ref * Update getTimestamp template specialisations * Make getFrameId not return const ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List comprehensions are much slower than numpy ranges, and broadcasting lets us remove the top line of this diff