Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows][ROS2] Fixed Windows build issues #277

Closed
wants to merge 2 commits into from
Closed

[Windows][ROS2] Fixed Windows build issues #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a1595
Adding Boost & opencv include dirs
seanyen May 21, 2019
0ba431c
Adding WINDOWS_EXPORT_ALL_SYMBOLS to cv_bridge
seanyen May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cv_bridge/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ find_package(OpenCV 3 REQUIRED
CONFIG
)

include_directories(include)
include_directories(include ${Boost_INCLUDE_DIRS} ${OpenCV_INCLUDE_DIRS})

if(NOT ANDROID)
add_subdirectory(python)
Expand Down
1 change: 1 addition & 0 deletions cv_bridge/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ ament_target_dependencies(${PROJECT_NAME}
"sensor_msgs"
)
target_link_libraries(${PROJECT_NAME} ${Boost_LIBRARIES} ${OpenCV_LIBRARIES})
set_target_properties(${PROJECT_NAME} PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS ON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be doing this or using visibility macros?


install(TARGETS ${PROJECT_NAME} DESTINATION lib)

Expand Down