cv_bridge: fix endianness comparison #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouchengming99
force-pushed
the
master
branch
from
e8f17b1 to
3c31a30
Compare
|
This also removes support for cv_bridge in python, so I don't know that it's a suitable PR. Can you reduce this to just the endianness fix? |
|
@zhouchengming99 friendly ping |
|
@mjcarroll Sorry, I just came from holiday. And of course, I will push a new PR just including the endianness fix. Thank you! |
Fix endianness comparison between source and platform, when source is little endian and platform is big endian, they are different too.
|
Superceded by #397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix endianness comparison between source and platform, when source
is little endian and platform is big endian, they are different too.