Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on irobot_events_executor #1

Closed
ijnek opened this issue Nov 8, 2022 · 2 comments · Fixed by #16
Closed

Dependency on irobot_events_executor #1

ijnek opened this issue Nov 8, 2022 · 2 comments · Fixed by #16

Comments

@ijnek
Copy link
Member

ijnek commented Nov 8, 2022

Running rosdep fails with irobot_events_executor because it isn't released into ROS 2, with the following message:

ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
hlvs_player: Cannot locate rosdep definition for [irobot_events_executor]

We should either:

@SammyRamone
Copy link
Contributor

I guess that iRobot does not really want to release it as an extra package as it would make more sens to finally integrate it into the normal rclcpp code base.
So I would say we should try to push finally merging the PRs of iRobot.

@ijnek
Copy link
Member Author

ijnek commented Nov 10, 2022

I agree, these changes must be available when it comes to releasing this package.
For now, for CI purposes, I'm going to add the irobot-ros/events_executor as a repository to build from source using action-ros-ci options in #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants