Package review

[ahcorde]

This package was never reviewed. I would suggest and comment some possible improvements.

• The maintainer of this pacakge is @dirk-thomas but I have not seen any commits or PRs from him, is he aware?
• The version of this package is 1.0.0 but this packages was never released, I supposed that this should be changed to 0.0.0.
• Icons are copied in the repository. Does make sense to download from the offical link?
• Does the name of the package should contain vendor?

@dirk-thomas and @brawner . I appreciate your thoughts, then I will follow up with PRs

[dirk-thomas]

The maintainer of this pacakge is @dirk-thomas but I have not seen any commits or PRs from him, is he aware?

No, please change the maintainer to someone else.

The version of this package is 1.0.0 but this packages was never released, I supposed that this should be changed to 0.0.0.

Yes, 0.0.0.

Does the name of the package should contain vendor?

The package name shouldn't include qt_gui since the icons have nothing to do with it. They can be used in any other context. Maybe a name like tango_icons_vendor?

---

The web links in the package description in the manifest file don't work for me.

[ahcorde]

• Version Version 0.0.0 this package was never released #3
• Renamed Remaned package qt_gui_icons -> tango_icons_vendor #4 (also the repository name)
• Maintainer Updated the maintainer #5
• Description links: Updated links on the description #6

[ahcorde]

this package has been reviewed, closing this issue.