Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assimp not found on some systems leading to nonsensical inclusion #44

Open
wants to merge 2 commits into
base: kinetic-devel
Choose a base branch
from
Open

Fix assimp not found on some systems leading to nonsensical inclusion #44

wants to merge 2 commits into from

Conversation

werner291
Copy link

Attempted fix #43, seems to work AFAIK, but please review.

@werner291
Fiz assimp not found on some systems leading to nonsensical inclusion
d47e90f 
Attempted fix ros#43, seems to work AFAIK, but please review.
@werner291
Copy link
Author

Weird, I am on Focal... It works fine here. I'm not sure what's going on in the test output... Something about packages not being found?

20:18:49 [rospack] Error: package 'pr2_description' not found

@clalancette
Copy link
Collaborator

20:18:49 [rospack] Error: package 'pr2_description' not found

That's actually not the warning; that is expected to happen. The warning is here: https://build.ros.org/job/Npr__collada_urdf__ubuntu_focal_amd64/3/cmake/

@werner291
Copy link
Author

werner291 commented Jul 21, 2021 •
edited
Loading

Oh hold on... Whoops, left in my debug statements.

Makes me wonder why the other tests passed at all.

@werner291
Update CMakeLists.txt
9c143e0 
Removed the debug statements accidentally left in.
@k-okada
Copy link
Contributor

k-okada commented Sep 10, 2021

not sure why pr2_description is not found, but it is released Aug 2020
ros/rosdistro#26154

I think we need this PR to solve #43

@k-okada
Copy link
Contributor

k-okada commented Dec 1, 2021

@ros-pull-request-builder retest this please

@k-okada
Copy link
Contributor

k-okada commented Dec 1, 2021

@clalancette it is strange, the test on ros build farm was passed as follows
(https://build.ros.org/job/Npr__collada_urdf__ubuntu_focal_amd64/5/)

スクリーンショット 2021-12-02 001023

The warning comes from CMake but it is cause by assimp
https://build.ros.org/job/Npr__collada_urdf__ubuntu_focal_amd64/5/console

06:58:43 CMake Warning (dev) at /usr/lib/x86_64-linux-gnu/cmake/assimp-5.0/assimpTargets.cmake:54 (if):
06:58:43   if given arguments:
06:58:43 
06:58:43     "ON"
06:58:43 
06:58:43   An argument named "ON" appears in a conditional statement.  Policy CMP0012
06:58:43   is not set: if() recognizes numbers and boolean constants.  Run "cmake
06:58:43   --help-policy CMP0012" for policy details.  Use the cmake_policy command to
06:58:43   set the policy and suppress this warning.
06:58:43 Call Stack (most recent call first):
06:58:43   /usr/lib/x86_64-linux-gnu/cmake/assimp-5.0/assimp-config.cmake:1 (include)
06:58:43   CMakeLists.txt:16 (find_package)
06:58:43 This warning is for project developers.  Use -Wno-dev to suppress it.
06:58:43 
06:58:43 -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.71.0/BoostConfig.cmake (found version "1.71.0") found components: system filesystem program_options

k-okada added a commit to k-okada/collada_urdf that referenced this pull request Dec 1, 2021
@k-okada
check PkgConfig first, then use assimp.cmake, to avoid compile warnin…
68f9674 
…g reported at ros#44 (comment)
@k-okada k-okada mentioned this pull request Dec 1, 2021
Closed
@k-okada
Copy link
Contributor

k-okada commented Dec 1, 2021

@clalancette or we adopt #46

@pazeshun pazeshun mentioned this pull request Aug 10, 2022
Open
@sloretz
Copy link
Collaborator

sloretz commented Mar 13, 2023

@ros-pull-request-builder retest this please

@mqcmd196
Copy link

mqcmd196 commented Aug 8, 2023

Kindly ping. Do you have any plans to merge and release this bug fix?

@k-okada k-okada mentioned this pull request Nov 2, 2023
Open
@Kanazawanaoaki Kanazawanaoaki mentioned this pull request Feb 5, 2024
Open
@mqcmd196 mqcmd196 mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake issue with the release on noetic
5 participants
@werner291 @clalancette @k-okada @sloretz @mqcmd196