Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosbag fix drops latching #1675

Closed
oceanusxiv opened this issue Mar 25, 2019 · 0 comments · Fixed by #1708
Closed

rosbag fix drops latching #1675

oceanusxiv opened this issue Mar 25, 2019 · 0 comments · Fixed by #1708

Comments

@oceanusxiv
Copy link

Hi

This is related to some of the issues mentioned before, namely #679 and #1049. Fundamentally this is the same issue, and the fix has been implemented in the underlying rosbag API. However specifically the fix has not seem to be propagated to the rosbag fix command, which still drops latching for /tf_static. Here's a minimal example.

test_2019-03-25-10-59-22.zip

then run

rosbag fix test_2019-03-25-10-59-22.bag test_2019-03-25-10-59-22_fixed.bag placeholder.bmr

placeholder.bmr is an empty file just to make the tool happy.

The result should be that the /tf_static topic going from latching to non latching between the old and new bag.

A cursory look at the python script seems to indicate that the fixbag2 function seems to still be using the old interface which is causing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants