Fix for upstream log4cxx #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flixr
force-pushed
the
fix_for_upstream_log4xx
branch
from
58c1e10 to
194a1ff
Compare
dirk-thomas
reviewed
Jan 22, 2020
flixr
force-pushed
the
fix_for_upstream_log4xx
branch
2 times, most recently
from
8639733 to
cd7d06d
Compare
|
This is tested and compatible with the released version 0.10.0 (from 2010) that is also in Debian/Ubuntu as well as the latest master from upstream. |
Fixes empty log lines on the console with upstream version of log4cxx. In upstream log4cxx the calls log4cxx::Level::getDebug(), etc. now return new pointers on every call. See https://issues.apache.org/jira/browse/LOGCXX-394 This resulted in rosconsole `Formatter::print` being called with an invalid level (`levels::Count`) and hence `color` was NULL and nothing printed (except the newline). So instead of calling getDebug(), directly compare the integer level which works in the released version and upstream. It should also be more efficient to directly compare integer level when the upstream version of log4cxx is used.
flixr
force-pushed
the
fix_for_upstream_log4xx
branch
from
cd7d06d to
3efe3a5
Compare
|
Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes empty log lines on the console with upstream version of log4cxx.
In upstream log4cxx the calls
log4cxx::Level::getDebug(), etc. now return new pointers on every call.See https://issues.apache.org/jira/browse/LOGCXX-394
This resulted in rosconsole
Formatter::printbeing called with an invalid level (levels::Count)and hence
colorwas NULL and nothing printed (except the newline).So instead of calling getDebug(), directly compare the integer level which works in the released version and upstream.
It should also be more efficient to directly compare integer level when the upstream version of log4cxx is used.
While here also change/fix console printer to print unknown levels.see #34