Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ament_cmake_catch2: 1.2.0-1 in 'foxy/distribution.yaml' [bloom] #30701

Merged
merged 1 commit into from
Sep 7, 2021
Merged

ament_cmake_catch2: 1.2.0-1 in 'foxy/distribution.yaml' [bloom] #30701

merged 1 commit into from
Sep 7, 2021

Conversation

marcoag
Copy link
Contributor

@marcoag marcoag commented Sep 6, 2021

Increasing version of package(s) in repository ament_cmake_catch2 to 1.2.0-1:

@marcoag marcoag requested a review from jacobperron as a code owner September 6, 2021 02:23
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I do wonder, where's Catch2 being pulled in by ament_cmake_catch2? It's not linked in, it's not vendored, it's not marked as a dependency.

@marcoag
Copy link
Contributor Author

marcoag commented Sep 7, 2021

True, is not doing that. To achieve proper correctness of the package we will vendor catch2 and add the dependency on a later release but that's still work in progress... 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants