Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for new cmake version requirement #14

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Dec 1, 2020

Update tag for new commit after merging ros2/Mimick#15

Testing --packages-up-to rcutils

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Stephen Brawner [email protected]

@brawner brawner requested a review from hidmic December 1, 2020 18:21
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI goes green!

@brawner
Copy link
Contributor Author

brawner commented Dec 1, 2020

Windows is yellow because the cmake version warnings are now only caused by googletest. Importantly the one caused by Mimick has been resolved.

@brawner brawner merged commit 2082184 into master Dec 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/update-cmake-version branch December 1, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants