-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clock class #189
Comments
I'm not sure it would make sense to implement the Clock class without the jump support. Otherwise users won't be able to know that time has skipped when the clock has changed. The class is trivial enough that the jump API and ability to pump it from a time source are important for confirming that the API is set that I'd rather not try to review just the simpler API/structure before the higher level functions are confirmed to work. The timer should have a clock associated with it to test for how long has elapsed. It's ticketed in rclcpp here: ros2/rclcpp#465 |
I see. I don’t feel comfortable I can have it implemented in reasonable time. I will pass on this ticket. What’s the right process? Just close this issue? Your original ticket still has all the tasks. |
Since we have the other ticket with the tracking info we could close this out. If you do find some time in the future this could be a good place to come back to. You could also start the implementation of the clock, but we just wouldn't plan to merge it until the other parts were implemented. |
Thanks! |
This is a portion of work from #186. I propose the first step to be an implementation of Clock class, similar to what's done in rclcpp/clock.hpp and in rclcpp/clock.cpp without jumps.
I found WallTimer class in rclpy, but I could not figure out a relationship between clock and timer.
@tfoote - I am looking forward to your feedback.
The text was updated successfully, but these errors were encountered: