Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests with MultiThreadedExecutor time out on some CI instances #268

Closed
jacobperron opened this issue Feb 5, 2019 · 0 comments · Fixed by #280
Closed

Tests with MultiThreadedExecutor time out on some CI instances #268

jacobperron opened this issue Feb 5, 2019 · 0 comments · Fixed by #280
Assignees
Labels
bug Something isn't working

Comments

@jacobperron
Copy link
Member

Bug report

Required Info:

  • Operating System:
    • Any
  • Installation type:
    • Source
  • Version or commit hash:
    • master
  • DDS implementation:
    • N/A
  • Client library (if applicable):
    • rclpy

Steps to reproduce issue

Unable to reproduce locally on Linux.

Example CI job failing: https://ci.ros2.org/job/ci_linux/6113/

Disabling this test resolves the issue:

def test_send_goal_multiple(self):
ac = ActionClient(
self.node,
Fibonacci,
'fibonacci',
callback_group=ReentrantCallbackGroup())
executor = MultiThreadedExecutor(context=self.context)
try:
self.assertTrue(ac.wait_for_server(timeout_sec=1.0))
future_0 = ac.send_goal_async(Fibonacci.Goal())
future_1 = ac.send_goal_async(Fibonacci.Goal())
future_2 = ac.send_goal_async(Fibonacci.Goal())
rclpy.spin_until_future_complete(self.node, future_0, executor)
rclpy.spin_until_future_complete(self.node, future_1, executor)
rclpy.spin_until_future_complete(self.node, future_2, executor)
self.assertTrue(future_0.done())
self.assertTrue(future_1.done())
self.assertTrue(future_2.done())
self.assertTrue(future_0.result().accepted)
self.assertTrue(future_1.result().accepted)
self.assertTrue(future_2.result().accepted)
finally:
ac.destroy()

@jacobperron jacobperron added the bug Something isn't working label Feb 5, 2019
This was referenced Feb 5, 2019
@jacobperron jacobperron changed the title ActionClient test with MultiThreadedExecutor times out on some CI instances Tests with MultiThreadedExecutor time out on some CI instances Feb 20, 2019
@jacobperron jacobperron self-assigned this Mar 4, 2019
@jacobperron jacobperron added ready Work is about to start (Kanban column) in progress Actively being worked on (Kanban column) and removed ready Work is about to start (Kanban column) labels Mar 4, 2019
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 5, 2019
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant